-->
Page 5 of 25

Re: WS2812B RGB LED Driver

PostPosted: Fri Feb 06, 2015 1:57 pm
by Markus Gritsch
Hey thanks!

It would be nice if you would rename the lgpio_ws2812 function to ws2812_write, so that it is consistent with the function naming of the other modules.

Also, please change the indentation from tabs to two spaces -- this seems to be the coding style being used already.

Re: WS2812B RGB LED Driver

PostPosted: Fri Feb 06, 2015 4:24 pm
by dereulenspiegel
Ok, I will do this. I imported the project to Eclipse so I was in the impression that the correct code style is already applied. I hope that someone can test this before my replacement modules arrive (15-31 days delivery time).

Re: WS2812B RGB LED Driver

PostPosted: Sat Feb 07, 2015 2:57 am
by Markus Gritsch
I tested it -- seems to work fine :)

Re: WS2812B RGB LED Driver

PostPosted: Wed Feb 11, 2015 10:13 am
by Markus Gritsch
dereulenspiegel wrote:If I get the ok from testers I will create a pull request.

Have you already made the pull request?