- Wed Sep 09, 2015 9:45 am
GregryCM wrote:I see in GitHub that IGRR had a concern with the proposed changes. I do not know C++, so this may not be correct, but is this how to address the concern?
IGRR suggested that I placed the temporary string in a separate line.
I've mentioned him that this line was a copy/paste from code of Makuna already present few lines above.
He admit that he missed that, but still suggest me to do the changes, so I will do them today, both in my code and Makuna's code.
Still, it doesn't prevent you to use current version since those lines are working since weeks/months.
EDIT : I've work on the issue, and it turns out to be a bit more complex than I thought.
It seems there was another bug in the original code. I've done a commit, but I'm not sure it will be the last.